Wo 16/oversized swap countersignal - #5
Merged
Conversation
WO-16: OVERSIZED_INSTANCE flagged on max-CPU alone, which cannot tell a genuinely oversized instance apart from one that is memory-bound despite low CPU. Fetch the CloudWatch SwapUsage metric alongside the existing CPU/connections fetch and suppress the finding when any measurable swap activity was observed during the window -- a countersignal independent of instance class, so no memory-size lookup table is needed.
wolint flagged the sentinel-check hunk as unattributed: the comment sat after the changed if-condition, not before it, so it didn't govern the line per the hunk-adjacency rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.